fix(keyfilter): regex test with the correct value onKeyPress#16085
Merged
cetincakiroglu merged 1 commit intoprimefaces:masterfrom Jul 25, 2024
Merged
fix(keyfilter): regex test with the correct value onKeyPress#16085cetincakiroglu merged 1 commit intoprimefaces:masterfrom
cetincakiroglu merged 1 commit intoprimefaces:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
rosenthalj
reviewed
Jul 24, 2024
| let val = valueCheck + cc; | ||
| const selectionStart = (<HTMLInputElement>e.currentTarget).selectionStart || 0; | ||
| const selectionEnd = (<HTMLInputElement>e.currentTarget).selectionEnd || 0; | ||
| let val = valueCheck.substring(0, selectionStart) + cc + valueCheck.substring(selectionEnd); |
Contributor
There was a problem hiding this comment.
I have not verified this but should lines 234 and 235
|| 0
be replaced with
|| Number.MAX_SAFE_INTEGER
This was referenced Aug 16, 2024
This was referenced Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #16084